Meek/fix autoscaling regions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 11, 2014 14:10
…og::Compute::AWS::Error: Duplicate => The permission \'1500008810-1-1-65535\' has already been authorized on the specified group"
| @@ -56,7 +56,8 @@ def get_slice(slice_string, *args) | |||
| # | |||
| ui.info("Inventorying servers in #{desc}") | |||
| cluster = Ironfan.load_cluster(cluster_name) | |||
| Chef::Config[:knife][:region] = cluster.servers.to_a.first.cloud(:ec2).region | |||
| cloud = cluster.servers.to_a.first.clouds.values.first.name.to_sym | |||
| Chef::Config[:knife][:region] = cluster.servers.to_a.first.cloud(cloud).region | |||
There was a problem hiding this comment.
Ah, I see. I'll bet things like this are littered all over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue I had with autoscale clusters and regions was that get_slice() had some ec2-specific code in it. This fixes that.
I also upgrade to fog 1.20 and excon 0.31 as those work for me and I was having some errors without them. It's your call on whether or not this is necessary. I've got it in one of my other open pull requests for core ironfan as it is needed to support something else I did.