Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GoogleSignIn support for Android and iOS. #49

Merged
merged 6 commits into from
Oct 26, 2024

Conversation

AvnishGameDev
Copy link
Contributor

Base implementation of migration to CredentialManager API for Google Login on Android.

Updated .gitignore to ignore Mac files like
.DS_Store
Mac thumbnails
and other residual files that Mac creates
Added Google login with CredentialManager
Note: The code is not cleaned / refactored yet.
Changes to be noted:

1. Renamed Source/ThirdParty/GoogleOneTapLibrary/GoogleOneTap_UPL.xml to GoogleOneTap_APL.xml as it's for Android only, and created a new GoogleOneTap_UPL for iOS.

2. Added Google_ClientId and Google_ReverseClientId to EIKSettings which are linked in Source/ThirdParty/GoogleOneTapLibrary/GoogleOneTap_UPL.xml

3. Added necessary frameworks to Source/ThirdParty/GoogleOneTapLibrary/IOS/Frameworks

4. Added GoogleSignIn.bundle to Source/ThirdParty/GoogleOneTapLibrary/IOS/Resources/GoogleSignIn.bundle

5. GoogleSignIn.bundle has multiple .strings files for localisation, not sure if safe to remove.
@AvnishGameDev
Copy link
Contributor Author

Added GoogleSignIn for iOS

Changes to be noted:

  1. Renamed Source/ThirdParty/GoogleOneTapLibrary/GoogleOneTap_UPL.xml to GoogleOneTap_APL.xml as it's for Android only, and created a new GoogleOneTap_UPL for iOS.

  2. Added Google_ClientId and Google_ReverseClientId to EIKSettings which are linked in Source/ThirdParty/GoogleOneTapLibrary/GoogleOneTap_UPL.xml

  3. Added necessary frameworks to Source/ThirdParty/GoogleOneTapLibrary/IOS/Frameworks

  4. Added GoogleSignIn.bundle to Source/ThirdParty/GoogleOneTapLibrary/IOS/Resources/GoogleSignIn.bundle

  5. GoogleSignIn.bundle has multiple .strings files for localisation, not sure if safe to remove.

@AvnishGameDev AvnishGameDev changed the title Migrated Google Login to new CredentialManager API Added GoogleSignIn support for Android and iOS. Oct 7, 2024
Migrated to Kotlin for GoogleSignIn on Android using custom AAR Library
also cleaned the code a bit
@AvnishGameDev
Copy link
Contributor Author

Migrated to custom Kotlin Library for GoogleSignIn on Android

@deveshmishrabetide deveshmishrabetide merged commit e11bfd2 into betidestudio:main Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants