-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xous-rs: remove unused features. #253
xous-rs: remove unused features. #253
Conversation
Signed-off-by: Jean-Pierre De Jesus DIAZ <me@jeandudey.tech>
The rationale is that xous-rs should have only architecture specific code, e.g.: riscv, arm, x86, etc. To make other crates that depend on it not specify the features. This could be useful when using xous-rs with `libstd` for example. Signed-off-by: Jean-Pierre De Jesus DIAZ <me@jeandudey.tech>
Is it possible to give edit permissions to the PR, so I can fold the version-bump that has to happen to the crates for this to pass our CI tests that ensures the published packages are in sync with the source tree? |
I think it's not possible to allow edit from forks on organizations, I could give access to the fork on the org if that is fine with you or re-open from the personal account 👀 |
Sent an invite to the repo that should allow to push to that branch and others. |
that...makes a lot of sense, i forgot that you're doing out of repo PR. I have accepted the invite, and I will add the version bumps onto this shortly. |
Crates bumped and dependencies published |
Following #252 made this to reduce some feature selection code.
Mainly to make
xous-rs
only have architecture specific code and not device specific, so that crates can depend on it without specifying features.Also removed the
target_os
detection code as it's not used.