fix(cs/serialization): Improve precision in date serialization #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify `BebopWriter.WriteDate` method to use a more precise algorithm - Introduce constants for ticks between epochs and date mask - Update date conversion to use milliseconds since Unix epoch - Apply bitmask to ensure consistent 64-bit representation This change should resolve hash discrepancies caused by date fields when serializing and deserializing objects. Testing: - Verified consistent hashing of original and round-tripped data - Ensured compatibility with existing implementations
…entations This commit modifies the date deserialization process in Bebop to ensure consistency with the other implementations and corrects a type mismatch issue. This change complements the previous fix for date serialization, providing a complete and correct solution for date handling across languages. - Modify `BebopReader.ReadDate()` method to use a more precise algorithm - Introduce constants for ticks between epochs and date mask - Update date conversion to use milliseconds since Unix epoch - Ensure UTC DateTime is always returned - Fix type mismatch between ulong and long in date calculation - Use unchecked conversion to handle potential overflow This change resolves inconsistencies in date representation when deserializing data.
…r implementations" This reverts commit 7a2de39.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BebopWriter.WriteDatemethod to use a more precise algorithmThis change should resolve hash discrepancies caused by date fields when serializing and deserializing objects.
Testing: