Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "unknown conversion error" on Windows #136

Closed

Conversation

jingyu9575
Copy link

Hi, yesterday I also saw this bug #133 on Windows, which breaks my build environment.

I do not know how to pass the conversion parameter to bin.js, but I think it can be fixed by providing two binary files cson2json.js and json2cson.js.

Also, it seems this check sometimes gives wrong conversion directions with some filenames on Linux. For example, json2cson Ericson2jsonline.json will actually execute cson2json instead because of the filename.

process.argv.toString().indexOf('cson2json')

Please have a look. Thank you!

@balupton
Copy link
Member

balupton commented Dec 9, 2020

bevry/boundation#24 needs to be implemented first otherwise the changes here will be reverted

@aminya
Copy link

aminya commented Apr 23, 2021

@balupton Well, #24 wasn't implemented ever. Any plan to finally merge this and let us use this tool?

@aminya aminya mentioned this pull request Apr 23, 2021
@jingyu9575
Copy link
Author

Lately I've been using cson2json ${process.platform === 'win32' ? 'cson2json/../' : ''}${source_file} to workaround that indexOf.

@balupton
Copy link
Member

balupton commented Jun 14, 2021

@aminya @sigod

@balupton Well, #24 wasn't implemented ever. Any plan to finally merge this and let us use this tool?

As I said, bevry/boundation#24 needs to be implemented, otherwise the changes here will be automatically reverted.

If you wish to put some of your own incentives into my life, then that would be great, otherwise, you can use your incentives to help accomplish your entitlements via say using the submitted PR directly or sending a PR for bevry/boundation#24. Otherwise, please wait, or take your attitude elsewhere.

Everything of @bevry's is done pro-bono in my spare time, and until it is funded well from donations, then it must compete against other life priorities and incentives. Please consider this.


@jingyu9575 thanks for your effort, sorry it's taking so long to do bevry/boundation#24, life has been difficult.

@balupton balupton closed this in 1502a8c Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants