get-installer: fix configuration scripts not retrieving installers

also fix performance by only checking for sd if we need it

commands/get-installer

@@ -342,7 +342,8 @@ function get_installer() (
 			    Exit on the first failure, skipping later utilities.
 
 			--quiet
-			    Do not output anything.
+			    If invoke, forwarded to installer.
+			    Otherwise, used to suppress missing installer error.
 		EOF
 		if test "$#" -ne 0; then
 			echo-error "$@"
@@ -379,11 +380,6 @@ function get_installer() (
 		help "No <items> were specified."
 	fi
 
-	# =====================================
-	# Dependencies
-
-	setup-util-sd --quiet --optional
-
 	# =====================================
 	# Action
 
@@ -396,13 +392,14 @@ function get_installer() (
 		# trim tap prefix
 		# clementtsang/bottom/bottom => bottom
 		util="${util##*/}"
-		# trim flags, and fix up superflous spaces at the start and end
-		# --classic code --classic => code
-		if command-exists sd; then
+		# if util has a space character, then it must have flags or superflous spaces, trim them
+		if [[ $util == *' '* ]]; then
+			# --classic code --classic => code
 			# (^| ) matches either start of the line, or a space character
 			# [-][^ ]+ matches a dash followed by one or more non-space characters
 			# so this is what converts the `--classic` flag into ``
 			# then we trim whitespace at the start and end
+			setup-util-sd --quiet
 			util="$(sd '(^| )[-][^ ]+' '' <<<"$util" | sd '^\s+|\s+$' '')"
 		fi
 
@@ -428,9 +425,7 @@ function get_installer() (
 				return 1
 			fi
 		elif test "$option_invoke" = 'no'; then
-			if test "$option_quiet" != 'yes'; then
-				print_line "$installer"
-			fi
+			print_line "$installer"
 			if test "$option_first_success" = 'yes'; then
 				return 0
 			fi

commands/setup-mac-brew

@@ -630,7 +630,7 @@ function setup_mac_brew() (
 		# update our listings appropriatley
 		local item installer
 		for item in "${requested_formulas[@]}"; do
-			installer="$(get-installer --first-success --quiet "$item" || :)"
+			installer="$(get-installer --quiet -- "$item" || :)"
 			if test -n "$installer"; then
 				if [[ $installer == 'setup-util-'* ]]; then
 					SETUP_UTILS+=("${installer#*setup-util-}")
@@ -650,7 +650,7 @@ function setup_mac_brew() (
 			HOMEBREW_FORMULAS+=("$item")
 		done
 		for item in "${requested_cask[@]}"; do
-			installer="$(get-installer --first-success --quiet "$item" || :)"
+			installer="$(get-installer --quiet -- "$item" || :)"
 			if test -n "$installer"; then
 				if [[ $installer == 'setup-util-'* ]]; then
 					SETUP_UTILS+=("${installer:11}")

sources/config.bash

@@ -24,7 +24,7 @@ function prepare_packages {
 
 	# remove inputs with dedicated installers
 	for item in "${inputs[@]}"; do
-		installer="$(get-installer --first-success --quiet -- "$item" || :)"
+		installer="$(get-installer --quiet -- "$item" || :)"
 		if test -n "$installer"; then
 			if [[ $installer == 'setup-util-'* ]]; then
 				util="${installer#*setup-util-}"