Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: ask: support editing the default value #99

Closed
balupton opened this issue Dec 1, 2021 · 3 comments
Closed

Improvement: ask: support editing the default value #99

balupton opened this issue Dec 1, 2021 · 3 comments
Assignees
@balupton
Labels
enhancement Improvement or suggestion
Milestone
Share Launch [v3]

Comments

@balupton
Copy link
Member

balupton commented Dec 1, 2021

No description provided.

@balupton balupton added the enhancement Improvement or suggestion label Dec 3, 2021
@balupton balupton added this to the --default for all! milestone Dec 5, 2021
@balupton balupton changed the title Allow ask to edit the default value, which would be useful for configuring unbounded lists Improvement: ask: support editing the default value Sep 9, 2023
@balupton
Copy link
Member Author

balupton commented Nov 4, 2023

Turns out read has an i argument so this is much easier than i could have ever hoped for
https://linuxcommand.org/lc3_man_pages/readh.html

@balupton balupton self-assigned this Nov 10, 2023
@balupton
Copy link
Member Author

Implemented in https://github.com/bevry/dorothy/tree/dev-defaults - need to fix up tests and will revise the --confirm handling across choose and confirm as well, as well as implement a consistent --linger functionality.

@balupton
Copy link
Member Author

Had to revert from master due to regressions. Fixed them locally. Will roll out --linger support in choose and confirm before pushing.

@balupton balupton reopened this Feb 23, 2024
balupton added a commit that referenced this issue Feb 25, 2024
@balupton
ask: support --default=<value>, close #99 (#213)
1979ed8 
* ask: support editing the default value /ref 6357fac
* ask: as read now supports defaults, redo the confirm flow /ref ddff467
* ask: use cursor rather than alt tty, implement --linger /ref 4d3e6fb
balupton added a commit that referenced this issue Feb 25, 2024
@balupton
ask: integrate #99 (#213)
8762807 
- implement `--linger`, default to enabled
- fix readline defaults failing when programatic stdin
- fix tests
- fix `echo-clear-lines` not retaining inlines which caused incorrect lines to be cleared
- adapt callers for new defaults and expectations
balupton added a commit that referenced this issue Feb 25, 2024
@balupton
ask: support --default=<value>, close #99 (#213)
975a387 
* ask: support editing the default value /ref 6357fac
* ask: as read now supports defaults, redo the confirm flow /ref ddff467
* ask: use cursor rather than alt tty, implement --linger /ref 4d3e6fb
balupton added a commit that referenced this issue Feb 25, 2024
@balupton
ask: integrate #99 (#213)
ced79b8 
- implement `--linger`, default to enabled
- fix readline defaults failing when programatic stdin
- fix tests
- fix `echo-clear-lines` not retaining inlines which caused incorrect lines to be cleared
- adapt callers for new defaults and expectations
balupton added a commit that referenced this issue Feb 25, 2024
@balupton
ask: integrate #99 (#213)
ffe2193 
- implement `--linger`, default to enabled
- fix readline defaults failing when programatic stdin
- fix tests
- fix `echo-clear-lines` not retaining inlines which caused incorrect lines to be cleared
- adapt callers for new defaults and expectations
@balupton balupton mentioned this issue Jun 12, 2024
Merged
balupton added a commit that referenced this issue Aug 8, 2024
@balupton
Merge pull request #229 from bevry/dev-defaults
a461bc6 
ask, choose, confirm: implement #99, #213, #188
@balupton balupton mentioned this issue Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balupton balupton

Labels
enhancement Improvement or suggestion
Milestone
Share Launch [v3]
Development

No branches or pull requests
1 participant
@balupton