$has queries break if test value coerces to/is false #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet :) Will merge that now. One thing to note is that this change will also add support for |
|
Makes sense - while I can see the use case for wanting to test to see if an array has a null element, I think that'd be better left as a comment on the $has test (with instructions on how to enable it), since I see it causing more confusion as the default. |
balupton
added a commit
that referenced
this pull request
Aug 21, 2012
balupton
added a commit
that referenced
this pull request
Aug 21, 2012
balupton
added a commit
that referenced
this pull request
Oct 29, 2012
- v1.3.1 October 29, 2012 - Fixed searching for `false` - Thanks to [Andrew Shults](https://github.com/andrewjshults) for [pull request #17](#17)
|
Sorry for the very long delay on this. Just got published to v1.3.1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like util.toArray converts false to [] rather than [false], so the Hash.hasIn test fails because the CS version gets converted to if(value) (line 127 of query-engine.coffee, line 91 of query-engine.js). It seems like this should test to see if the value isn't undefined rather than coercible to true, since false, 0, and '' may be valid tests (false is in my case).
I added a test specifically for this and it looks like all the other tests are still passing, but since I'm just getting started with this project wasn't sure if there are any other areas I should poke around to make sure I didn't break anything.
Cheers!
Andrew