Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help users discover the correct version of the official examples #109

Merged
merged 4 commits into from
Apr 16, 2021

Conversation

inodentry
Copy link
Contributor

@inodentry inodentry commented Mar 11, 2021

  1. Change all links to point to the latest branch (which is the release version, not main)
  2. Explicitly instruct users to git checkout the correct version when they clone the repo to run the examples
  1. Add a card on the Learn page linking to the examples

content/learn/book/getting-started/_index.md Outdated Show resolved Hide resolved
templates/learn.html Outdated Show resolved Hide resolved
@@ -8,8 +8,8 @@ page_template = "book-section.html"

You have reached the end of The Bevy Book! And unfortunately, we haven't even scratched the surface of Bevy's features! Eventually this book will cover almost every facet of Bevy, but until then we recommend checking out:

* **[The Bevy Examples](https://github.com/bevyengine/bevy/tree/main/examples#examples)**: We create an example for every major Bevy feature. This is currently the best way to learn Bevy's features and how to use them.
* **[Breakout](https://github.com/bevyengine/bevy/blob/main/examples/game/breakout.rs)**: A small "breakout" clone that illustrates what a real Bevy game looks like.
* **[The Bevy Examples](https://github.com/bevyengine/bevy/tree/latest/examples#examples)**: We create an example for every major Bevy feature. This is currently the best way to learn Bevy's features and how to use them.
Copy link
Contributor

@memoryruins memoryruins Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link continues to use #examples at the end, so if #109 (comment) decides to not use #examples, perhaps this should be aligned with the other links.

bors bot pushed a commit to bevyengine/bevy that referenced this pull request Mar 12, 2021
1. The instructions in the main README used to point users to the git main version. This has likely misdirected and confused many new users. Update to direct users to the latest release instead.
2. Rewrite the notice in the examples README to make it clearer and more concise, and to show the `latest` git branch.

See also: bevyengine/bevy-website#109 for similar changes to the website and official book.
cart and others added 2 commits April 16, 2021 12:28
Co-authored-by: memoryruins <memoryruinsmusic@gmail.com>
Co-authored-by: memoryruins <memoryruinsmusic@gmail.com>
@cart cart merged commit 052ec98 into bevyengine:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants