Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gizmos line styles release notes #1336

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

lynn-lumen
Copy link
Contributor

Adds release notes for 12394_Gizmo_line_styles

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tackle both the line styles and the joint types in the same section here.

@lynn-lumen
Copy link
Contributor Author

We should tackle both the line styles and the joint types in the same section here.

Should I leave them in seperate files or can I merge the contents to something more coherent?
If so, are there rules for what that file should be named?

@alice-i-cecile
Copy link
Member

For now, leave the file name of the current one, and remove the S-Needs-Release-Note tag on the PR corresponding to the file you're removing. We need better tech for merging PRs, but not this cycle.

@alice-i-cecile
Copy link
Member

I've removed the tag from bevyengine/bevy#12252 accordingly :)

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the unification. Thanks!

@alice-i-cecile
Copy link
Member

@lynn-lumen you need to update the _release_notes.toml to remove the offending section as well.

auto-merge was automatically disabled June 4, 2024 21:54

Head branch was pushed to by a user without write access

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm giving in: I'll let the format-on-save win this round.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 4, 2024
@lynn-lumen
Copy link
Contributor Author

Ooh, I didn't notice all the new whitespace :/ I'm sorry for that 😓

Merged via the queue into bevyengine:main with commit 6472e9f Jun 4, 2024
10 checks passed
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jun 4, 2024

Ha no, I've been fighting this for a week. I think it's better this way, and since there's very little else in flight this won't cause merge conflicts. See #1200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants