Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing outdated note about Windows support for dynamic_linking #628

Merged
merged 3 commits into from
May 8, 2023

Conversation

zendril
Copy link
Contributor

@zendril zendril commented May 4, 2023

I tested the dynamic linking on Windows 11 and it works. I also heard from others in the Discord chats that it seems to be a resolved issue. Thus a small PR to update the docs to reflect that.

Here is the relevant discussion with Alice in the General room on Discord where they call out that they believe it is fixed: https://discord.com/channels/691052431525675048/691052431974465548/1103445630237540362

@IceSentry
Copy link
Contributor

IceSentry commented May 4, 2023

Using the dynamic_linking feature still doesn't work for me on windows 10.

I still get the issues mentioned in this thread bevyengine/bevy#1110

I'm surprised it works for anyone on windows honestly. Did you test it with default features disabled?

@IceSentry
Copy link
Contributor

To clarify a bit, it does work when enabling the optimization like mentioned in the linked thread, but it seems wrong to not mention to users that they need to do additional configurations to get it to work.

@zendril
Copy link
Contributor Author

zendril commented May 4, 2023

Perhaps that is why. I did do the optimizations.

Ok, so it seems like it isn't 'broken' completely (which is the way the previous text read to me).. seems like it needs a bit more clarification that it will only work on windows when enabling the optimizations?

@cart
Copy link
Member

cart commented May 4, 2023

Ok, so it seems like it isn't 'broken' completely (which is the way the previous text read to me).. seems like it needs a bit more clarification that it will only work on windows when enabling the optimizations?

This is a valuable enough feature that I think we should let Windows users know that there is a path available. I agree that we should just clarify what that path is.

Copy link
Contributor

@paul-hansen paul-hansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related issue that can be closed when this is merged: #131

content/learn/book/getting-started/setup/_index.md Outdated Show resolved Hide resolved
@zendril
Copy link
Contributor Author

zendril commented May 8, 2023

@paul-hansen Applied your suggested edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants