Examples update #720
Merged
Examples update #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
examples-update
branch
from
9d34b57
to
740a100
Compare
|
Just added the token under the CLOUDFLARE_PAGES variable! |
|
the workflow has been merged in #721 and executed: https://github.com/bevyengine/bevy-website/actions/runs/5586192733 I updated this PR to use the new domains, should be good to go 👍 |
mockersf
force-pushed
the
examples-update
branch
from
ba9a666
to
ca09e36
Compare
cart
approved these changes
Jul 19, 2023
github-merge-queue bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Aug 9, 2023
# Objective This example stopped being built for the website after the example-building was reworked in (bevyengine/bevy-website#720 + #9168). This seems to have just been a mistake when defining this particular example's metadata. See bevyengine/bevy-website#726 ## Solution Update its metadata to indicate that it works with wasm.
cart
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Aug 10, 2023
# Objective This example stopped being built for the website after the example-building was reworked in (bevyengine/bevy-website#720 + #9168). This seems to have just been a mistake when defining this particular example's metadata. See bevyengine/bevy-website#726 ## Solution Update its metadata to indicate that it works with wasm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
It needs a new secret for the cloudflare token. @cart I can either give you a token or show you how to setup the account. That secret is not needed to merge this PR, it will only be used when a new version of the examples is built
Building the examples is not done at each time the website is built anymore, but on demand. That should be triggered once for every new Bevy version.
Examples are built in a matrix job by batches of 50 examples. There are three batches done currently, so we're OK until we reach 150 examples, at which point a new batch will need to be added.
All the steps building are using the examples from
latest, but the tooling frommain. This is to be able to use the changes from bevyengine/bevy#9168. CI won't work before it's merged.This is what this workflow execution looks like:
Why running on macos? Because GitHub runners on macos have more resources than on windows/linux, and it's significantly faster (around x2)