Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative path based shader file imports stopped working #10004

Closed
superdump opened this issue Oct 3, 2023 · 1 comment
Closed

Relative path based shader file imports stopped working #10004

superdump opened this issue Oct 3, 2023 · 1 comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this!
Milestone
0.12

Comments

@superdump
Copy link
Contributor

Bevy version

main at 4eb9b9f

What you did

#import "something.wgsl" as something

What went wrong

It doesn't give any errors. If an incorrect path is provided, then ERROR bevy_asset::server: path not found is logged, but with the correct path there's no error, the shader just doesn't run.

Additional information

From what @DGriffin91 can tell it's Bevy Asset V2 #8624, works just before, doesn't work after, doesn't work on current main.
@superdump superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Regression Functionality that used to work but no longer does. Add a test for this! labels Oct 3, 2023
@superdump superdump added this to the 0.12 milestone Oct 3, 2023
@JMS55
Copy link
Contributor

JMS55 commented Oct 7, 2023

Fixed by #10030?

@JMS55 JMS55 closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
2 participants
@superdump @JMS55