Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate view binding imports and positions #15645

Open
bas-ie opened this issue Oct 4, 2024 · 0 comments
Open

Consolidate view binding imports and positions #15645

bas-ie opened this issue Oct 4, 2024 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@bas-ie
Copy link
Contributor

bas-ie commented Oct 4, 2024

What problem does this solve or what need does it fill?

  • consolidate view binding imports under bevy_render
  • standardise shader view uniform bindings to group 0, binding 0
  • consider standardising globals binding position to group 0, binding 1 and moving its import to bevy_render

See cart's comment on now-closed 2022 PR #5535. Adopting the closed PR may provide a good starting point.
@bas-ie bas-ie added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Feature A new feature, making something new possible S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! labels Oct 4, 2024
@bas-ie bas-ie mentioned this issue Oct 4, 2024
Closed
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bas-ie @BenjaminBrienen