Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flat normals if normal attribute is not found #2396

Closed
PravinKumar95 opened this issue Jun 26, 2021 · 4 comments
Closed

Use flat normals if normal attribute is not found #2396

PravinKumar95 opened this issue Jun 26, 2021 · 4 comments
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature

Comments

@PravinKumar95
Copy link

PravinKumar95 commented Jun 26, 2021

What problem does this solve or what need does it fill?

Most cad/cae files does not contain normals to reduce data. Bevy panics if normals aren't found

What solution would you like?

Use flat normals if normal attribute is not found

What alternative(s) have you considered?

Using a custom shader would solve the issue

Additional context

image

@PravinKumar95 PravinKumar95 added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Jun 26, 2021
@jakobhellermann
Copy link
Contributor

This is already done in the main branch: #1808

@mockersf
Copy link
Member

As mentioned above, this is done in the GLTF loader, but it still fails for a mesh from another source

@PravinKumar95
Copy link
Author

PravinKumar95 commented Jun 27, 2021

Why not calculate flat normals in the shader if normal attribute is not found. Why do we need to create extra vertex data?

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jul 8, 2021
@PravinKumar95
Copy link
Author

I think this addressed in 0.6 release. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature
Projects
None yet
Development

No branches or pull requests

4 participants