Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong normals of built-in torus shape #4896

Closed
YoshieraHuang opened this issue Jun 2, 2022 · 2 comments
Closed

Wrong normals of built-in torus shape #4896

YoshieraHuang opened this issue Jun 2, 2022 · 2 comments
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Comments

@YoshieraHuang
Copy link
Contributor

Bevy version

"0.7"

Relevant system information

`AdapterInfo { name: "Radeon RX 590 Series", vendor: 4098, device: 26591, device_type: DiscreteGpu, backend: Vulkan }`

What you did

I try to build my outline shader using vertex extrusion method. This method is strongly related to the normals of vertices.

What went wrong

I tests many meshes and my code does well expect the built-in torus shape.
This is the result of torus imported from Blender and it looks good:

blender_torus

This is the result of built-in torus and it looks not so good:

bevy_torus

After carefully testing, I find that some of the calculated normals of built-in torus may be wrong.

I will check the code later and find what goes wrong actually.

@YoshieraHuang YoshieraHuang added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jun 2, 2022
@hymm
Copy link
Contributor

hymm commented Jun 2, 2022

this should be fixed on main in #4520.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-Math Fundamental domain-agnostic mathematical operations and removed S-Needs-Triage This issue needs to be labelled labels Jun 2, 2022
@YoshieraHuang
Copy link
Contributor Author

this should be fixed on main in #4520.

Thank you. This also fixes my problem. I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

3 participants