Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break apart monolithic TextStyle type #5519

Closed
alice-i-cecile opened this issue Aug 1, 2022 · 3 comments
Closed

Break apart monolithic TextStyle type #5519

alice-i-cecile opened this issue Aug 1, 2022 · 3 comments
Labels
A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@alice-i-cecile
Copy link
Member

This should probably be done in a future PR just to not let this one grow too much, but doing this for TextStyle should probably be done too.

Originally posted by @IceSentry in #5513 (comment)

Sibling to #5511, and should be done for the same reasons.
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Aug 1, 2022
@alice-i-cecile alice-i-cecile moved this to Todo in UI Aug 1, 2022
@alice-i-cecile alice-i-cecile added this to UI Aug 1, 2022
@Nilirad
Copy link
Contributor

Nilirad commented Aug 1, 2022 •
edited
Loading

Pasting what I said in #5511:

Not sure if in-topic, but I think it would be good UX to have font weight/style and text decoration as their own components:

  • Underline (as or with an enum with Normal, Dotted, Wavy, etc variants)
  • Overline
  • LineThrough
  • Bold
  • Italic

@rparrett rparrett added the A-Text Rendering and layout for characters label Jun 23, 2024
@rparrett
Copy link
Contributor

rparrett commented Jun 23, 2024 •
edited
Loading

I'm slightly confused by this issue -- I don't think TextStyle has ever been used as a Component and since #1245 (pre-this-issue) there's no way it really could be so I'm not sure how breaking it up would make things more ergonomic.

This could potentially become relevant again if "text sections as entities" gains traction in the future.

@alice-i-cecile alice-i-cecile changed the title Break apart monolithic TextStyle component Break apart monolithic TextStyle type Jun 23, 2024
@alice-i-cecile
Copy link
Member Author

Yeah, sorry about that, the wording was definitely misleading. I think that "text styles as entities" is still an interesting direction, but this isn't super actionable as is.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in UI Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
UI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rparrett @alice-i-cecile @Nilirad