(Hierarchical) Stage Labels, Conditions, and Transitions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move rfc into folder gotta learn to follow instructions fix image fix image take 2
tidied up execution stack example edit bulleted list wording Made small edit to the summarized benefits for better clarity. simplify condition pseudocode More diplomatic motivation, more clarification on labels, transitions, compositions, and tied back to the plugin ecosystem.
reworded some stuff for clarity and fixed typos mentioned that conditions can be made read-only cleaned up implementation strategy rebranded Set to Config
maniwani
force-pushed
the
stage-labels-rfc
branch
4 times, most recently
from
7560aa5
to
de448c1
Compare
idk
maniwani
force-pushed
the
stage-labels-rfc
branch
3 times, most recently
from
8b9167f
to
8d27e34
Compare
reworded a fair amount of stuff
maniwani
force-pushed
the
stage-labels-rfc
branch
from
8d27e34
to
92b61b2
Compare
|
Closing since Some differences are the complete removal of stages (with the addition of an explicit sync point system) and a simpler state machine (no stack whatsover). Any looping and nesting will involve running a nested schedule inside an exclusive system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RENDERED
Summary
Reorganizes the system scheduling API with better separation of responsibilities. Introduces a single schedule executor, reincarnates stages into topological system labels, and splits run criteria into conditions and transitions.
Motivation
The current system scheduling API packs great functional coverage into a tasteful number of tools, but there are some key things missing, and the overall cohesion isn't as good as it could be.
See #2801 for more background.