feat!(KeyBindings): Allow pure modifier keysets #1074
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the engine was unable to handle any combination of modifiers without keysets, for example: An input of keypress alt -> would trigger an action bound to ctrl+alt This commit makes it so that any keyboard state composed of a combination of modifiers without any other keys is interpreted as a keyset of 'none' + mods. For consumers intending to bind to these combinations, none is not required as we sanitize internally, but it can also be set, e.g.: Shift+none == shift or ctrl+shift == ctrl+shift+none
badosu
force-pushed
the
badosu/allow-pure-modifiers-keysets
branch
from
156faa9 to
6b9ccfa
Compare
badosu
commented
Nov 15, 2023
…osu/allow-pure-modifiers-keysets
rhys-vdw
reviewed
Oct 14, 2024
…osu/allow-pure-modifiers-keysets
When an action was bound by both scancodes and keycodes, it would unbind only from keycode bindings on /unbindaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the engine was unable to handle any combination of modifiers without keysets, for example:
An input of keypress ctrl+alt -> would trigger an action bound to alt
This commit makes it so that any keyboard state composed of a combination of modifiers without any other keys is interpreted as a keyset of 'none' + mods.
For consumers intending to bind to these combinations, none is not required as we sanitize internally, but it can also be set, e.g.:
Shift+none == shift or ctrl+shift == ctrl+shift+none
Fix #1071