Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cmake import targets part 2 #1746

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use cmake import targets part 2 #1746

wants to merge 4 commits into from
+31 −224

Conversation

n-morales
Copy link
Contributor

Depends on #1737

This adds imported targets for SDL and OpenAL

@n-morales n-morales force-pushed the use-cmake-import-targets-2 branch from 4aa1de8 to f092fc6 Compare November 3, 2024 18:45
@n-morales n-morales marked this pull request as ready for review November 3, 2024 20:33
@p2004a p2004a self-requested a review November 3, 2024 21:07
@n-morales n-morales force-pushed the use-cmake-import-targets-2 branch from f092fc6 to 5700171 Compare November 24, 2024 14:39
@n-morales
Copy link
Contributor Author

I fixed the COMPILE_ONLY flag for SDL2. I'm running into some issues testing with MSVC so I'll work on that; I'll mark this as draft so it doesn't get accidentally merged in since we don't have MSVC CI

@n-morales n-morales marked this pull request as draft November 24, 2024 14:49
@n-morales
Copy link
Contributor Author

This PR should fix the issue for MSVC beyond-all-reason/vclibs64#2

@n-morales n-morales force-pushed the use-cmake-import-targets-2 branch from 5700171 to 39ce193 Compare December 8, 2024 15:55
@n-morales n-morales marked this pull request as ready for review December 8, 2024 16:04
@n-morales n-morales force-pushed the use-cmake-import-targets-2 branch from 39ce193 to 077849c Compare December 13, 2024 15:36
@n-morales n-morales mentioned this pull request Dec 13, 2024
Draft
@n-morales n-morales force-pushed the use-cmake-import-targets-2 branch from 077849c to f7ec826 Compare January 8, 2025 20:43
@saurtron saurtron requested a review from p2004a January 9, 2025 14:55
@n-morales n-morales force-pushed the use-cmake-import-targets-2 branch from f7ec826 to ab54d8d Compare January 18, 2025 16:13
p2004a
p2004a approved these changes Jan 19, 2025
View reviewed changes
Copy link
Collaborator

@p2004a p2004a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

Just please confirm you tested the builds with this and that linked libraries look correctly and it's ready to merge (sorry if you did already and I missed it somewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p2004a p2004a p2004a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-morales @p2004a