Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require a 3rd parameter for ShareResources(teamID, 'unit'). #1837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't require a 3rd parameter for ShareResources(teamID, 'unit'). #1837

wants to merge 2 commits into from

Conversation

saurtron
Copy link
Collaborator

Work done

  • Remove early check for third argument to ShareResources
    • The error message is improved and only applied for resources actually needing it.

Related tasks

sprunk
sprunk approved these changes Dec 20, 2024
View reviewed changes
rts/Lua/LuaUnsyncedCtrl.cpp Outdated Show resolved Hide resolved
@saurtron
No need to check arguments length here since lua_isnumber will return
b84bcad 
false anyways when the argument isn't present.
@saurtron saurtron added status: candidate PRs that should be good to go or important for next release area: Lua API labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprunk sprunk sprunk approved these changes

Assignees
No one assigned
Labels
area: Lua API status: candidate PRs that should be good to go or important for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring.ShareResources(teamID, "units", nil) breaks
2 participants
@saurtron @sprunk