-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spring.GetSoundDevices. #1841
base: master
Are you sure you want to change the base?
Add Spring.GetSoundDevices. #1841
Conversation
a6e1d9d
to
fb765a6
Compare
Perhaps do it the full way already and return tables?
|
- only 'name' field for now.
Co-authored-by: sprunk <spr.ng@o2.pl>
Co-authored-by: sprunk <spr.ng@o2.pl>
while (*deviceSpecStr != '\0') { | ||
devices.emplace_back(deviceSpecStr); | ||
|
||
while (*deviceSpecStr++ != '\0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a copy-paste code from the previous implementation, but it's hard to read and comprehend if it works as it should. Would be great to rewrite it to something more comprehensible like a combo of std::find_if / std::find_if_not
Overall LGTM |
Work Done
Remarks