Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waterbump_4tiles.dds to basecontent and use it as the default water.normalTexture #1867

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

AntlerForce
Copy link
Contributor

@AntlerForce AntlerForce commented Dec 31, 2024

BAR mappers have been using this improved water bump texture many map releases now, here are some example screenshots showing the difference between the proposed texture and the current default:

Old Texture:
waterbump
New Texture:
waterbump_4tiles

Screenshots using the Old Texture:

screen_2024-12-30_20-25-20-096
screen_2024-12-30_20-18-02-451
screen_2024-12-30_20-12-11-480
screen_2024-12-30_19-50-12-535
screen_2024-12-30_20-25-43-368
screen_2024-12-30_20-07-26-592
screen_2024-12-30_20-06-49-237
screen_2024-12-30_20-05-41-287

The old texture often looks like lumps/frothy foam rather than the waves it should represent. Here are some replicated screenshots showing how the new texture looks in place:

screen_2024-12-30_20-28-35-962
screen_2024-12-30_20-27-29-993
screen_2024-12-30_20-21-18-763
screen_2024-12-30_20-13-47-734
screen_2024-12-30_20-04-13-706
screen_2024-12-30_20-03-45-618
screen_2024-12-30_20-02-54-408
screen_2024-12-30_19-53-28-355

Details

  • The format of the new texture is DXT1 .dds, created from a .png with nvtt_export.exe and --mip-filter 0 --quality 3
  • Changes the default numTiles setting from 1 to 4. The min of 1 and max of 16 remain the same.
  • Does not affect maps that already specify a custom normalTexture and numTiles
  • This is my first PR to engine, I have already built locally and tested my changes but please inspect to ensure I haven't done anything silly.

@lhog
Copy link
Collaborator

lhog commented Dec 31, 2024

Looking better indeed.
Do you have @Beherith permission to use the texture?

@AntlerForce
Copy link
Contributor Author

Looking better indeed. Do you have @Beherith permission to use the texture?

No, I wanted to request a review of this PR from Beherith for that reason but I'm not seeing how to do that.

@lhog lhog requested a review from Beherith December 31, 2024 20:36
@lhog lhog added enhancement New feature or request status: needs-testing labels Dec 31, 2024
@AntlerForce
Copy link
Contributor Author

Behe says yes to adding it to basecontent https://discord.com/channels/549281623154229250/1323379143215419482/1323828649106870387

@lhog
Copy link
Collaborator

lhog commented Jan 1, 2025

Great. Saving here for posterity:
image

@lhog lhog merged commit 306fd06 into beyond-all-reason:master Jan 1, 2025
2 checks passed
@AntlerForce AntlerForce deleted the waterbump4tiles branch January 1, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants