Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9 and Symfony Var-Dumper 6 Support #82

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Laravel 9 and Symfony Var-Dumper 6 Support #82

merged 1 commit into from
Feb 12, 2022

Conversation

gofish543
Copy link
Contributor

@gofish543 gofish543 commented Jan 29, 2022

This should provide Laravel 9, and thus, Symfony 6 support. The Var Dumper for Symfony appears to be backward compatible between 5.x and 6.x

Issue: #81

@justRau
Copy link

justRau commented Feb 4, 2022

Laravel 9 will be PHP 8+ (https://laravel.com/docs/8.x/releases#support-policy), so maybe php requirement in composer.json should be updated as well?

@ThibaudDauce
Copy link

Laravel 9 will be PHP 8+ (https://laravel.com/docs/8.x/releases#support-policy), so maybe php requirement in composer.json should be updated as well?

No because the composer.json is the requirements of your package not the requirements of your dependencies. If you start using PHP 8 features inside the source of this repository, yes you should bump the PHP version but if it's only your dependencies you're fine.

@ThibaudDauce
Copy link

@mpociot Is it possible to merge this?

@gofish543
Copy link
Contributor Author

@mpociot Bump

@ghost
Copy link

ghost commented Feb 12, 2022

Please merge indeed :-)

@mpociot mpociot merged commit 33a19c6 into beyondcode:master Feb 12, 2022
@mpociot
Copy link
Member

mpociot commented Feb 12, 2022

Thank you

@miken32
Copy link

miken32 commented Feb 12, 2022

Thank you for the merge @mpociot Looking forward to the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants