Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNFPA MH add missing facility relations #4034

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

nick-beyondessential
Copy link
Contributor

Issue #: Maui-987

Changes:

Simple migration to add missing facility relations for Marshal Islands in UNFPA


Screenshots:

Copy link
Contributor

@biaoli0 biaoli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey everyone the hierarchy man is back in town 😁 Thanks for maintaining the hierarchy again!
One small suggestion for waiting async functions to resolve its promise.

where code in (${arrayToDbString(codes)})
and id not in (select child_id from entity_relation where entity_hierarchy_id = '${hierarchyId}');
`);
entities.map(entity =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
entities.map(entity =>
Promise.all(entities.map(async (entity) =>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Good catch thank you

@nick-beyondessential nick-beyondessential merged commit 52ee19d into dev Aug 4, 2022
@nick-beyondessential nick-beyondessential deleted the maui-987-add-rmi-facility-relationships branch August 4, 2022 03:17
@nick-beyondessential nick-beyondessential mentioned this pull request Aug 4, 2022
3 tasks
@chris-pollard chris-pollard mentioned this pull request Aug 8, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants