Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lesmis cannot export as PNG file #4055

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix lesmis cannot export as PNG file #4055

merged 1 commit into from
Aug 3, 2022

Conversation

biaoli0
Copy link
Contributor

@biaoli0 biaoli0 commented Jul 29, 2022 •
edited
Loading

Changes:

Downgrade recharts version as before.

@rohan-bes
Copy link
Collaborator

@billli0 any background on why this version change actually broke the png exports?

@biaoli0
Copy link
Contributor Author

biaoli0 commented Jul 29, 2022

@rohan-bes No quite sure.. recharts doesn't have a migration guide from v1 to v2, or release note, which makes thing hard to debug.

rohan-bes
rohan-bes approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@rohan-bes rohan-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's all good then. Worth knowing about this issue if we want/need to upgrade in the future...

@biaoli0 biaoli0 merged commit 9b45fd9 into dev Aug 3, 2022
@biaoli0 biaoli0 deleted the fix-lesmis-cannot-export-as-png branch August 3, 2022 04:54
@biaoli0 biaoli0 mentioned this pull request Aug 3, 2022
Closed
3 tasks
@chris-pollard chris-pollard mentioned this pull request Aug 8, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-bes rohan-bes rohan-bes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biaoli0 @rohan-bes