Fix meditrak-app hoisting config #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.yarnrc.yml method does not work, using package.json method see https://yarnpkg.com/configuration/yarnrc#nmHoistingLimits
meditrak-app was providing a babel plugin, now that it is correctly not hoisting, we need to add this dependency back into the root repo.
biaoli0
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://beyondessential.slack.com/archives/D01A1LRAG9W/p1657848268725059
This was causing issues with running meditrak-app locally. You would need to
yarn installinside packages/meditrak-app to get packages to show up in packages/meditrak-app/node_modules, otherwise the local build would fail. After this fix a singleyarn installat root level is all that is needed again.--
Fix: .yarnrc.yml method does not work, using package.json method instead
see https://yarnpkg.com/configuration/yarnrc#nmHoistingLimits
--
Passing appcenter build: https://appcenter.ms/orgs/Beyond-Essential/apps/Tupaia-MediTrak-Android/build/branches/fix-meditrak-app-hoisting/builds/1256