Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence noisy warning when building @tupaia/ui-components #4082

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

rohan-bes
Copy link
Collaborator

We currently see a lot of this warning when building ui-components:

[ui-components] Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "true" for @babel/plugin-proposal-private-property-in-object.
[ui-components] The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
[ui-components]         ["@babel/plugin-proposal-private-methods", { "loose": true }]
[ui-components] to the "plugins" section of your Babel config.

So I followed the recommendation to silence the warning

…oposal-private-methods' in @tupaia/ui-components
@rohan-bes rohan-bes enabled auto-merge (squash) August 9, 2022 07:05
@rohan-bes rohan-bes merged commit 297e2dd into dev Aug 9, 2022
@rohan-bes rohan-bes deleted the silence-noisy-warning-uic branch August 9, 2022 07:44
@rohan-bes rohan-bes mentioned this pull request Aug 12, 2022
3 tasks
@edmofro edmofro mentioned this pull request Aug 22, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants