Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-issue]: Fixed intermittent failure in dateRangePicker.test.js #4166

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

rohan-bes
Copy link
Collaborator

I experienced the rarest intermittent test failure (date rolled over in the very short time between this test starting and asserting)

I swear to never again have this test fail due to date not being mocked!

@rohan-bes rohan-bes enabled auto-merge (squash) September 13, 2022 00:58
Copy link
Contributor

@chris-pollard chris-pollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool little package! LGTM

@rohan-bes rohan-bes merged commit 547fd07 into dev Sep 13, 2022
@rohan-bes rohan-bes deleted the mock-date-in-datepicker-tests branch September 13, 2022 05:17
This was referenced Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants