Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-issue]: Fix ESLint for web-config-server #4189

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

kael89
Copy link
Collaborator

@kael89 kael89 commented Sep 23, 2022

Issue #:

[No issue]

Changes:

ESLint for web-config-server is currently broken.

The packages I added are required because of babel-plugin-module-resolver - see babelrc.js. This package enables aliased imports such as:

import { login, oneTimeLogin, logout } from '/authSession';

// Instead of
import { login, oneTimeLogin, logout } from '../../authSession';

On this occasion, perhaps the project should reconsider whether it's beneficial using babel-plugin-module-resolver. I personally think that it's a good idea in principle, but since it's not natively supported it may not be worth the extra hassle.

Or it may be that you love it and want to use it in more packages... In any case, it sounds like something the Open Source Community may be able to help with, so let me know 😄

@edmofro edmofro merged commit 82f3a2f into dev Sep 29, 2022
@edmofro edmofro deleted the fix-web-config-server-eslint branch September 29, 2022 02:38
@edmofro edmofro mentioned this pull request Sep 29, 2022
@avaek avaek mentioned this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants