RN-175: Add order columns transform (p1. switch to managing columns explicitly in report-server) #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-bes
force-pushed
the
rn-175-p1-transform-table
branch
from
2999651
to
b99c161
Compare
- Dropped support for where in excludeColumns
rohan-bes
force-pushed
the
rn-175-p1-transform-table
branch
from
b99c161
to
a4b7916
Compare
biaoli0
suggested changes
Oct 5, 2022
There was a problem hiding this comment.
@rohan-bes Woohoo! Really love this new TransformTable feature! Can't wait to see the power and flexibilities it brings to report-server!
Just got a few minor suggestions on the codes and unit tests.
packages/report-server/src/__tests__/reportBuilder/transform/mergeRows.test.ts
Outdated
Show resolved
Hide resolved
packages/report-server/src/reportBuilder/transform/aliases/keyValueByFieldAliases.ts
Outdated
Show resolved
Hide resolved
packages/report-server/src/reportBuilder/transform/aliases/keyValueByFieldAliases.ts
Outdated
Show resolved
Hide resolved
packages/report-server/src/reportBuilder/transform/functions/updateColumns.ts
Show resolved
Hide resolved
…ite undefined values to the table
…the viz-builder) (#4192)
biaoli0
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-175:
Part 1 of 3.
We want to introduce an ability to order the columns of the data in the viz-builder. However, before we do this, we need to actually have an explicit order to the columns in the report-server in the first place.
There are other reasons it is advantageous to switch to tracking an explicit column order as well:
sum(col1:col5))Here we are introducing a simple data-structure called a
TransformTable. It manages the rows of the table as before, but also separately tracks an array of columns. It has a number of utility methods for manipulating the rows/columns atomically, so that the caller doesn't need to ensure they're kept in sync manually.Tried to make this review as digestable as possible for the reviewer by breaking up changes to each transform step into its own commit, so going commit-by-commit might be the easiest approach.