[no-issue]: Convert web-config-server tests to jest #4194
Conversation
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "clearMocks": true, | |||
| "collectCoverageFrom": ["<rootDir>/src/**/*.js)"], | |||
There was a problem hiding this comment.
It seems that nobody was checking test coverage in JS packages for the last 14 months 😛
| @@ -1,10 +1,3 @@ | |||
| const getPlugins = api => { | |||
| if (api.env(['development', 'test'])) { | |||
| return ['istanbul']; | |||
There was a problem hiding this comment.
Build-related change, should be fine
| ...baseConfig, | ||
| rootDir: '.', | ||
| moduleNameMapper: { | ||
| '^/aggregator(.*)$': '<rootDir>/src/aggregator$1', |
There was a problem hiding this comment.
I couldn't find a way to generalise these (without more elaborate folder scanning logic).
I also tried the following transformation. It throws an error because it is also applied to node_modules packages:
'^/(.*)$': '<rootDir>/src/$1'
...config-server/src/__tests__/apiV1/dataBuilders/generic/table/tableOfDataValues/testTotals.js
Show resolved
Hide resolved
| }, | ||
| }; | ||
|
|
||
| describe.skip('UserHasAccess', () => { |
There was a problem hiding this comment.
These tests actually fail and have been disabled for as long as I remember them... I'd suggest to just delete them
There was a problem hiding this comment.
I'm happy to delete them, what about you @edmofro
...onfig-server/src/__tests__/apiV1/dataBuilders/helpers/calculateOperationForAnalytics.test.js
Show resolved
Hide resolved
| let app; | ||
|
|
||
| beforeAll(async () => { | ||
| app = new TestableApp(await createApp()); |
There was a problem hiding this comment.
I think that createApp() needs not be async: app.js
It is not async in central-server
There was a problem hiding this comment.
Yep, doesn't need async, can you remove it @kael89? 🙏
There was a problem hiding this comment.
Happy to do so in another PR though! (Don't want touch production code in this one)
| entityHierarchy: { findById: findEntityHierarchyById }, | ||
| }; | ||
|
|
||
| describe('ReportServerDataBuilder', () => { |
There was a problem hiding this comment.
These are new tests? Thanks so much for adding them! 🙌
There was a problem hiding this comment.
No just a rename and a bit of refactoring. Git thinks they are new though 🙂
...onfig-server/src/__tests__/apiV1/dataBuilders/helpers/calculateOperationForAnalytics.test.js
Show resolved
Hide resolved
| }, | ||
| }; | ||
|
|
||
| describe.skip('UserHasAccess', () => { |
There was a problem hiding this comment.
I'm happy to delete them, what about you @edmofro
| let app; | ||
|
|
||
| beforeAll(async () => { | ||
| app = new TestableApp(await createApp()); |
There was a problem hiding this comment.
Yep, doesn't need async, can you remove it @kael89? 🙏
kael89
force-pushed
the
convert-web-config-server-tests-to-jest
branch
from
53e4b74
to
dae0003
Compare
1 package left (
central-server) and then mocha can go! 🎉Most of the job was done using a community codemod.
A few other tweaks too, see commits for an overview