[no-issue]: Fix upserting dynamic columns #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-bes
commented
Oct 17, 2022
| newColumns[columnName] = table.hasColumn(columnName) | ||
| ? table.getColumnValues(columnName) // Upserting a column, so fill with current column values | ||
| : new Array(table.length()).fill(undefined); // Creating a new column, so fill with undefined | ||
| newColumns[columnName] = new Array(table.length()).fill(undefined); |
There was a problem hiding this comment.
Since we now re-insert the skipped rows, there's no need for the conditional upsert logic, just overwrite everything and let the skipped rows re-insert themselves if they exist.
biaoli0
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
@rohan-bes Thanks for adding the unit test and the fix! Just got a minor suggestion, but can pre approve.
| @@ -51,7 +51,14 @@ const insertColumns = (table: TransformTable, params: InsertColumnsParams, conte | |||
| values, | |||
| })); | |||
|
|
|||
| return table.upsertColumns(columnUpserts); | |||
| // Drop, then re-insert the original skipped rows | |||
| const rowsToDrop = Object.keys(skippedRows).map(rowIndexString => parseInt(rowIndexString)); | |||
There was a problem hiding this comment.
Suggested change
| const rowsToDrop = Object.keys(skippedRows).map(rowIndexString => parseInt(rowIndexString)); | |
| const rowsToDrop = Object.keys(skippedRows); |
Should keys of skippedRows are number?
There was a problem hiding this comment.
Unfortunately even though we set them as numbers, they come out as strings. That's JS for you 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://beyondessential.slack.com/archives/C01MAA3NKM1/p1665977231627499:
This issue is a bit rare, but when we're using dynamic columns to override an existing column, the old values from the existing column are kept.