No issue: Accept permissionGroupName as undefined #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This behaviour seems very specific to legacy reports, can we move the check to there? Also, if a utility function is only used in one place I'd say it probably doesn't need to exist. Let's move the internals to EditDashboardVisualisation handler? |
IgorNadj
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Issue: https://beyondessential.slack.com/archives/C04QFLD87E3/p1678940272063209
Legacy report doesn't have permission group, it throws error in this permission check. It is only used in EditDashboardVisualisation handler, so I think it is safe not to test.