Waitp 1121 loading indicator not visible #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acdunham would you mind resolving these merge conflicts before I review. Thanks |
…:beyondessential/tupaia into waitp-1121-loading-indicator-not-visible
…thub.com/beyondessential/tupaia into waitp-1121-loading-indicator-not-visible
tcaiger
reviewed
Apr 5, 2023
| const noData = viewContent.data && viewContent.data.length === 0; | ||
|
|
||
| if (isLoading) return <LoadingIndicator />; |
There was a problem hiding this comment.
Nice find. I'm not sure what it did before either but I think this is a good choice of component to use. I know there is no design but I think the transparent white background is probably overkill so could we have just the loading spinner with no background? Don't mind if you add a prop to the LoadingIndicator component or just add the CircularProgress component directly.
There was a problem hiding this comment.
@tcaiger Just updated this for you
tcaiger
approved these changes
Apr 10, 2023
merge in latest dev before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1121
Changes:
LoadingIndicatorcomponents, which I am assuming is correct? Not sure what it used to look like (ticket implies it used to have the loader there before). There is info in the card about how to replicate the issue.