Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAITP-1144 verify email view also loads explore #4428

Merged
merged 1 commit into from
Apr 19, 2023
Merged

WAITP-1144 verify email view also loads explore #4428

merged 1 commit into from
Apr 19, 2023

Conversation

alexd-bes
Copy link
Contributor

Issue WAITP-1144

Changes:

  • Update verify email view to load the explore view behind the modal as well as showing the landing modal. Should work for both success and error cases of verifying emails.

tcaiger
tcaiger reviewed Apr 5, 2023
View reviewed changes
packages/web-frontend/src/sagas/watchUser/watchSetVerifyEmailToken.js
@@ -4,6 +4,7 @@ import {
openEmailVerifiedPage,
setOverlayComponent,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setOverlayComponent,

Don't need this import anymore

tcaiger
tcaiger approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@tcaiger tcaiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I left a comment to remove the unused import but otherwise looks good.

@alexd-bes alexd-bes merged commit db2c22c into dev Apr 19, 2023
@alexd-bes alexd-bes deleted the waitp-1144-verify-email-redirect branch April 19, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcaiger tcaiger tcaiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexd-bes @tcaiger