RN-864: Add 'Delete' button to Data-Tables page in the Admin Panel #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched create route over to BESAdmin permissions
rohan-bes
commented
Apr 14, 2023
There was a problem hiding this comment.
Chose to delete this, and instead use BES Admin permissions requirements for creating data-tables.
Did this because:
- Currently we don't have a way of ensuring that a user has access to the External Database Connection they're creating/editing their data-table with.
- We could add this permissions check, but I figured that since it's really only going to be internal users creating data-tables for the forseable future, using BES Admin for everything data-tables is sufficient.
- If reviewer feels differently I'm happy to introduce appropriate logic for ensuring that a user doesn't create/edit data-tables which use external database connections that they don't have access to.
chris-pollard
approved these changes
Apr 17, 2023
merge latest dev before testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-864:
Added missing 'Delete' button. Also chose to tighten up permissions on creating data-tables, more explanation in PR comments.