Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAITP-1177 Update validation to allow 0 #4502

Merged
merged 3 commits into from
Jun 14, 2023
Merged

WAITP-1177 Update validation to allow 0 #4502

merged 3 commits into from
Jun 14, 2023

Conversation

EMcQ-BES
Copy link
Contributor

Issue #: WAITP-1177

Changes:

  • Allow a value of 0 in mobile validation
  • Remove unnecessary empty string check (Empty string is already falsey)

@EMcQ-BES EMcQ-BES merged commit 06743a2 into dev Jun 14, 2023
@EMcQ-BES EMcQ-BES deleted the waitp-1177-validate-arithmatic-zeros branch June 14, 2023 21:06
tcaiger pushed a commit that referenced this pull request Jun 19, 2023
@EMcQ-BES @avaek @tcaiger
WAITP-1177 Update validation to allow 0 (#4502)
edcaf11 
Co-authored-by: Andrew <vanbeekandrew@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcaiger tcaiger tcaiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EMcQ-BES @tcaiger @avaek