Waitp 1259 map components to ts #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents-ts'" This reverts commit e31052b.
alexd-bes
commented
May 29, 2023
alexd-bes
commented
May 29, 2023
alexd-bes
commented
May 29, 2023
tcaiger
reviewed
Jun 1, 2023
| @@ -2,9 +2,9 @@ | |||
| * Tupaia | |||
| * Copyright (c) 2017 - 2023 Beyond Essential Systems Pty Ltd | |||
| */ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
We are not supporting the Disasters feature moving forward and that is the only use case for the disaster icons so let's remove all of them and any references to them in this package. thanks
tcaiger
reviewed
Jun 1, 2023
tcaiger
requested changes
Jun 12, 2023
tcaiger
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1259: Convert
ui-map-componentsto TypescriptChanges:
ui-map-componentsto TypescriptApologies for not splitting this out - everything is very intertwined so splitting out was a little too complex