WAITP-1287: Dashboard dropdown #4655
Conversation
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| background: ${PANEL_GREY}; |
There was a problem hiding this comment.
What do you think of putting this grey in the theme? I'm guessing that if we ever themed the app for a particular organisation then this colour may potentially be a part of that?
There was a problem hiding this comment.
yes that's a good idea. We will have to come up with a scheme to make all these theme colors make sense at some point. Perhaps it will need to evolve over time. I've added a panel section to the theme and used that through out the side bar for now.
| any, | ||
| any | ||
| >; | ||
| export type DashboardsRequest = Request<any, any, any, any>; | ||
|
|
||
| export class DashboardsRoute extends Route<DashboardsRequest> { | ||
| public async buildResponse() { | ||
| const { query, ctx } = this.req; | ||
| const { organisationUnitCode, projectCode } = query; |
There was a problem hiding this comment.
We were thinking about removing organisationUnitCode in favour of entityCode, right? What do you think of doing the web-server side of it now, so that eventually it just slots right into the entity server as and when changes are made? I know it's not strictly part of this ticket, but something to consider I guess?
There was a problem hiding this comment.
@acdunham The back end needs a bit of a clean up anyway so I reckon if the front end looks good let's not let the back end hold it up
| const dashboards = await ctx.services.central.fetchResources('dashboards', { | ||
| filter: { root_entity_code: baseEntity.code }, | ||
| }); |
There was a problem hiding this comment.
A dashboard attached to an entity can also appear on any of that entity's children (depending on the existence of dashboard items which are usually specific to entity types) which is why I was checking against ancestors.
This route handler needs another fix-up pass anyway so I'm happy to pick that up in a separate PR
Issue #: WAITP-1287: Dashboard dropdown
Changes:
Screenshots: