Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAITP-1212: Tupaia Web Breadcrumbs #4669

Merged
merged 7 commits into from
Jul 2, 2023

Conversation

tcaiger
Copy link
Contributor

@tcaiger tcaiger commented Jun 22, 2023

Issue #: WAITP-1212: Breadcrumbs

Changes:

  • add breadcrumbs using the entity ancestors route

Note: the breadcrumbs are missing the project entity but that is an issue with the api.


Screenshots:

image

@tcaiger tcaiger changed the title WAITP-1212: Breadcrumbs WAITP-1212: Tupaia Web Breadcrumbs Jun 29, 2023
Copy link
Contributor

@alexd-bes alexd-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great! Just one teeny request in there from me, but pre-approving.

position: absolute;
top: 10px;
top: 5px;
left: 10px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change these to rems?

@tcaiger tcaiger merged commit 1b6d339 into epic-frontend-rewrite Jul 2, 2023
@tcaiger tcaiger deleted the waitp-1212-breadcrumbs branch July 2, 2023 21:50
tcaiger added a commit that referenced this pull request Jul 12, 2023
* add breadcrumbs component

* breadcrumbs

* Update useEntityAncestors.ts

* Update Breadcrumbs.tsx
tcaiger added a commit that referenced this pull request Jul 12, 2023
* add breadcrumbs component

* breadcrumbs

* Update useEntityAncestors.ts

* Update Breadcrumbs.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants