WAITP-1209: Map entities part 2 #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexd-bes
approved these changes
Jun 28, 2023
| this.map?.fitBounds(bounds, { | ||
| animate: true, | ||
| }); | ||
| this.map?.fitBounds(bounds, { animate: true }); |
There was a problem hiding this comment.
Did you end up finding a nice animation for this one?
There was a problem hiding this comment.
I did get it working pretty nicely with map.fitToBounds and it while it was nice and smooth it was much less snappy and a very different feel from how it currently works. So I just went for feature parity and added a note to the list of polish as a reminder to look at it later with Edwin.
| export const useEntitiesWithLocation = (projectCode?: string, entityCode?: string) => | ||
| useEntities(projectCode, entityCode, { | ||
| params: { fields: ['parent_code', 'code', 'name', 'type', 'bounds', 'region'] }, | ||
| }); |
tcaiger
added a commit
that referenced
this pull request
Jul 12, 2023
* setup map entites * wip * wip * re organise project view * mobile search layout * polygon layer * map animation * fix mini map * Update Dashboard.tsx * merging * map overlay data * add Map overlays feature folder * useEntitiesWithLocation * typescript * remove test code * Update InteractivePolygon.tsx
tcaiger
added a commit
that referenced
this pull request
Jul 12, 2023
* setup map entites * wip * wip * re organise project view * mobile search layout * polygon layer * map animation * fix mini map * Update Dashboard.tsx * merging * map overlay data * add Map overlays feature folder * useEntitiesWithLocation * typescript * remove test code * Update InteractivePolygon.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: WAITP-1209: Map entities part 2
Changes:
Screenshots: