Waitp 1231 base matrix part 2 #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
changed the base branch from
epic-frontend-rewrite
to
waitp-1231-base-matrix-component
tcaiger
reviewed
Jul 10, 2023
| @@ -1265,171 +1265,341 @@ export const MatrixConfigSchema = { | |||
| }, | |||
| "presentationOptions": { | |||
| "description": "Allows for conditional styling", | |||
| "type": "object", | |||
There was a problem hiding this comment.
any idea what's going on here. Is it just formatting?
There was a problem hiding this comment.
This is when I ran generate on the types package, because the build was failing because the types had changed
* setup map entites * wip * wip * re organise project view * mobile search layout * polygon layer * map animation * fix mini map * Update Dashboard.tsx * merging * map overlay data * add Map overlays feature folder * useEntitiesWithLocation * typescript * remove test code * Update InteractivePolygon.tsx * set up * fix api * marker layer * Update types.d.ts * update map layout * wip map overlays * revert map control layout * Update useEntities.ts * copy lesmis * wip * Update MapOverlayList.tsx * default map overlay * radius overlays * navigate to dashboard * fix scroll * measure level * refactor marker layer * refactor useDefaultMapOverlay * types * useEntitiesByMeasureLevel * Update MapOverlaysRoute.ts * fix active entity * Update MarkerLayer.tsx * add comments * Update processMeasureData.ts * refactor useDefaultMapOverlay
alexd-bes
added a commit
that referenced
this pull request
Jul 11, 2023
* WAITP-1231 Working table * WIP * Update Matrix.tsx * Fix linting errors * convert to use context * Update hooks * Fix issues * Reorganise files * reorganise context * Working table * Remove enlarged cell modal file * Working modal * Tidy up * Update MatrixCell.tsx * Tidy up hover * Add cell handling for markdown * fix types * WAITP-1231 fixes * Delete types.d.ts * Update index.ts * Fix type error * Waitp 1231 base matrix part 2 (#4714) * Working legend, grouped columns * Apply location values * Tidy up * Styled column groups * Tiy up files * Add in hidden column titles * Update hidden column title and config types * Generate types * Move the buttons * WAITP-1222: Marker layer (#4686) * setup map entites * wip * wip * re organise project view * mobile search layout * polygon layer * map animation * fix mini map * Update Dashboard.tsx * merging * map overlay data * add Map overlays feature folder * useEntitiesWithLocation * typescript * remove test code * Update InteractivePolygon.tsx * set up * fix api * marker layer * Update types.d.ts * update map layout * wip map overlays * revert map control layout * Update useEntities.ts * copy lesmis * wip * Update MapOverlayList.tsx * default map overlay * radius overlays * navigate to dashboard * fix scroll * measure level * refactor marker layer * refactor useDefaultMapOverlay * types * useEntitiesByMeasureLevel * Update MapOverlaysRoute.ts * fix active entity * Update MarkerLayer.tsx * add comments * Update processMeasureData.ts * refactor useDefaultMapOverlay * Fix merge conflicts * Fix conflict errors --------- Co-authored-by: Tom Caiger <caigertom@gmail.com> --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
tcaiger
added a commit
that referenced
this pull request
Jul 12, 2023
* WAITP-1231 Working table * WIP * Update Matrix.tsx * Fix linting errors * convert to use context * Update hooks * Fix issues * Reorganise files * reorganise context * Working table * Remove enlarged cell modal file * Working modal * Tidy up * Update MatrixCell.tsx * Tidy up hover * Add cell handling for markdown * fix types * WAITP-1231 fixes * Delete types.d.ts * Update index.ts * Fix type error * Waitp 1231 base matrix part 2 (#4714) * Working legend, grouped columns * Apply location values * Tidy up * Styled column groups * Tiy up files * Add in hidden column titles * Update hidden column title and config types * Generate types * Move the buttons * WAITP-1222: Marker layer (#4686) * setup map entites * wip * wip * re organise project view * mobile search layout * polygon layer * map animation * fix mini map * Update Dashboard.tsx * merging * map overlay data * add Map overlays feature folder * useEntitiesWithLocation * typescript * remove test code * Update InteractivePolygon.tsx * set up * fix api * marker layer * Update types.d.ts * update map layout * wip map overlays * revert map control layout * Update useEntities.ts * copy lesmis * wip * Update MapOverlayList.tsx * default map overlay * radius overlays * navigate to dashboard * fix scroll * measure level * refactor marker layer * refactor useDefaultMapOverlay * types * useEntitiesByMeasureLevel * Update MapOverlaysRoute.ts * fix active entity * Update MarkerLayer.tsx * add comments * Update processMeasureData.ts * refactor useDefaultMapOverlay * Fix merge conflicts * Fix conflict errors --------- Co-authored-by: Tom Caiger <caigertom@gmail.com> --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
tcaiger
added a commit
that referenced
this pull request
Jul 12, 2023
* WAITP-1231 Working table * WIP * Update Matrix.tsx * Fix linting errors * convert to use context * Update hooks * Fix issues * Reorganise files * reorganise context * Working table * Remove enlarged cell modal file * Working modal * Tidy up * Update MatrixCell.tsx * Tidy up hover * Add cell handling for markdown * fix types * WAITP-1231 fixes * Delete types.d.ts * Update index.ts * Fix type error * Waitp 1231 base matrix part 2 (#4714) * Working legend, grouped columns * Apply location values * Tidy up * Styled column groups * Tiy up files * Add in hidden column titles * Update hidden column title and config types * Generate types * Move the buttons * WAITP-1222: Marker layer (#4686) * setup map entites * wip * wip * re organise project view * mobile search layout * polygon layer * map animation * fix mini map * Update Dashboard.tsx * merging * map overlay data * add Map overlays feature folder * useEntitiesWithLocation * typescript * remove test code * Update InteractivePolygon.tsx * set up * fix api * marker layer * Update types.d.ts * update map layout * wip map overlays * revert map control layout * Update useEntities.ts * copy lesmis * wip * Update MapOverlayList.tsx * default map overlay * radius overlays * navigate to dashboard * fix scroll * measure level * refactor marker layer * refactor useDefaultMapOverlay * types * useEntitiesByMeasureLevel * Update MapOverlaysRoute.ts * fix active entity * Update MarkerLayer.tsx * add comments * Update processMeasureData.ts * refactor useDefaultMapOverlay * Fix merge conflicts * Fix conflict errors --------- Co-authored-by: Tom Caiger <caigertom@gmail.com> --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1231: Matrix Ui component part 2
Changes:
typespackagehideColumnTitleslabeldescriptioncategoryPresentationOptionsapplyLocationNOTE: This is an extension off WAITP-1231 part 1, so some changes are actually from the initial branch
Screenshots:
Hidden column titles
Markdown presentation options
Category presentation options
Grouped columns
Apply location option