Waitp 1316 Chart table #4720
Merged
Waitp 1316 Chart table #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexd-bes
commented
Jul 11, 2023
| (dashboard: DashboardsResponse) => dashboard.dashboardName === dashboardName, | ||
| ) || dashboards[0]; | ||
| data?.find((dashboard: DashboardsResponse) => dashboard.dashboardName === dashboardName) || | ||
| data[0]; |
There was a problem hiding this comment.
This was because I was getting some weird TS errors, and this fixed it
tcaiger
reviewed
Jul 11, 2023
| ${({ theme }) => { | ||
| let hexString = theme.palette.text.primary.replace('#', ''); | ||
| hexString = hexString.length === 3 ? hexString.replace(/(.)/g, '$1$1') : hexString; | ||
| return `#${hexString}33`; |
There was a problem hiding this comment.
This seems a bit clunky to me and maybe a bit fragile too as the primary text color could be 3 digit hex, 6 digit hex or also rgba which is what it is actually by default in the default theme. Maybe we could use lighten instead?
tcaiger
reviewed
Jul 11, 2023
| display: flex; | ||
| position: relative; | ||
| align-content: stretch; | ||
| -webkit-box-align: stretch; | ||
| align-items: stretch; | ||
| height: ${({ $isEnlarged, $hasData }) => { |
There was a problem hiding this comment.
this line is fine- just noticed that webkit selector above which is now redundant.
tcaiger
approved these changes
Jul 11, 2023
tcaiger
pushed a commit
that referenced
this pull request
Jul 12, 2023
* WAITP-1216: tab buttons * WIP * Rename files * rearrange files * Remove unused types * Update Chart.tsx * Fix colors
tcaiger
pushed a commit
that referenced
this pull request
Jul 12, 2023
* WAITP-1216: tab buttons * WIP * Rename files * rearrange files * Remove unused types * Update Chart.tsx * Fix colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1316: Chart table
Changes:
Chartcomponent to have toggle buttons and table option when enlargedrechartscontainers, to let it be handled byrechartsScreenshots: