WAITP-1223: Tupaia web map legend #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
commented
Jul 11, 2023
tcaiger
commented
Jul 11, 2023
alexd-bes
approved these changes
Jul 12, 2023
| return ( | ||
| <> | ||
| <MobileMapLegend /> | ||
| <DesktopMapLegend /> | ||
| <MobileMapLegend Legend={LegendComponent} /> |
There was a problem hiding this comment.
This is very minor, but what do you think about having the LegendComponent as children of the different legend wrappers?
| </Wrapper> | ||
| ); | ||
| export const DesktopMapLegend = ({ Legend }) => { | ||
| return <Wrapper>{Legend}</Wrapper>; |
There was a problem hiding this comment.
I wonder if, since this is so simple now, if it can just be a wrapper styled component inside MapLegend?
|
|
||
| const SeriesDivider = styled.div` | ||
| height: 0; | ||
| border-bottom: 1px solid #ffffff22; |
There was a problem hiding this comment.
Do we want this colour to come from the theme at all? I dunno if it will change ever, but if the theme is a light theme then the divider wouldn't show, for example.
tcaiger
added a commit
that referenced
this pull request
Jul 12, 2023
* setup map legend * update legend props * mobile map legend * Update MobileMapLegend.tsx * refactor map legend * fix console warnings
tcaiger
added a commit
that referenced
this pull request
Jul 12, 2023
* setup map legend * update legend props * mobile map legend * Update MobileMapLegend.tsx * refactor map legend * fix console warnings
tcaiger
added a commit
that referenced
this pull request
Jul 13, 2023
* setup map legend * update legend props * mobile map legend * Update MobileMapLegend.tsx * refactor map legend * fix console warnings fix export styles (#4727)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: WAITP-1223: Tupaia web map legend
Changes:
Screenshots: