Waitp 1338 add matrices #4725
Merged
Waitp 1338 add matrices #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
approved these changes
Jul 11, 2023
| @@ -126,6 +134,7 @@ export const EnlargedDashboardItem = () => { | |||
| /> | |||
| )} | |||
| </TitleWrapper> | |||
| {currentReport?.description && <Subheading>{currentReport?.description}</Subheading>} | |||
| export const Matrix = ({ viewContent, isEnlarged = false }: MatrixProps) => { | ||
| const { columns, rows, ...config } = viewContent; | ||
|
|
||
| const getPlaceholderImage = () => { |
There was a problem hiding this comment.
This is very minor but I reckon this would be easier to read if it was placed outside of the Matrix component just above it and just took config or presentationOptions and categoryPresentationOptions as props
| `; | ||
|
|
||
| // This is a recursive function that parses the rows of the matrix into a format that the Matrix component can use. | ||
| const parseRows = ( |
There was a problem hiding this comment.
There's a lot going on here but separating it out into parseRows and parseColumns and all the comments help clarify it a lot.
tcaiger
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Placeholder images for dashboard * Working matrix * Add description and handle no data * Add comments * Fix grouping and width * Move getPlaceholderImage
tcaiger
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Placeholder images for dashboard * Working matrix * Add description and handle no data * Add comments * Fix grouping and width * Move getPlaceholderImage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1338: Add matrix component to Tupaia web
Changes:
ui-componentsMatrix componentuseReportto use correct endpointsScreenshots:
Description (subheader)
Enlarged matrix
Dashboard placeholder matrix image
