Waitp 1239 static text visuals #4732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
reviewed
Jul 13, 2023
tcaiger
reviewed
Jul 13, 2023
tcaiger
reviewed
Jul 13, 2023
| }; | ||
|
|
||
| export const SingleDownloadLink = ({ data, config }: SingleDownloadLinkProps) => { | ||
| const { value } = data![0]; |
There was a problem hiding this comment.
I see that data is optional above but won't this throw an error if data is undefined?
tcaiger
reviewed
Jul 13, 2023
| }; | ||
|
|
||
| export const SingleDate = ({ data }: SingleDateProps) => { | ||
| const { value } = data![0]; |
There was a problem hiding this comment.
Wont this error if data is undefined?
tcaiger
reviewed
Jul 13, 2023
tcaiger
reviewed
Jul 13, 2023
tcaiger
reviewed
Jul 13, 2023
packages/tupaia-web/src/features/DashboardItem/DashboardItemContent.tsx
Outdated
Show resolved
Hide resolved
tcaiger
reviewed
Jul 13, 2023
packages/tupaia-web/src/features/DashboardItem/DashboardItemContent.tsx
Outdated
Show resolved
Hide resolved
tcaiger
requested changes
Jul 13, 2023
Co-authored-by: Tom Caiger <caigertom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1239: Static Text Visuals
Changes:
singleDate,singleValue,singleDownloadLink,multiValueandmultiValueRowviewContenttoreportandconfigand updated types and other terminology to matchScreenshots: