Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN-931: Refactor download files component to TS #4736

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

tcaiger
Copy link
Contributor

@tcaiger tcaiger commented Jul 14, 2023

Issue #: RN-931: Convert Download Files Component to TS

Changes:

  • Convert Download Files Component to TS
  • Refactor slightly to match tupaia-web patterns

Screenshots:

image image

@tcaiger tcaiger changed the title refactor download files component to ts RN-931: Refactor download files component to TS Jul 16, 2023
@@ -7,7 +7,8 @@
"outDir": "dist",
"lib": [
"es6",
"dom"
"dom",
"es2019"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition to the config was needed to support the Object.fromEntries( in the DownloadVisual component

@tcaiger tcaiger merged commit 5f4ec30 into epic-frontend-rewrite Jul 16, 2023
@tcaiger tcaiger deleted the rn-931-download-files-ui-component branch July 16, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant