Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAITP-1318 Add single entity request route #4738

Merged
merged 1 commit into from
Jul 16, 2023
Merged

WAITP-1318 Add single entity request route #4738

merged 1 commit into from
Jul 16, 2023

Conversation

EMcQ-BES
Copy link
Contributor

Issue #: WAITP-1318

Changes:

  • Add single entity route

EMcQ-BES
EMcQ-BES commented Jul 16, 2023
View reviewed changes
packages/tupaia-web-server/src/routes/EntityRoute.ts
Comment on lines +10 to +11
// TODO: WAITP-1278 Move this to types
export type EntityRequest = Request<any, any, any, any>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4731 is in progress but having some issues in codeship to fixup, if we merge this first, I'll make the update on that branch

tcaiger
tcaiger approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@tcaiger tcaiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@EMcQ-BES EMcQ-BES merged commit 6f70315 into epic-frontend-rewrite Jul 16, 2023
@EMcQ-BES EMcQ-BES deleted the waitp-1318-entity-route branch July 16, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcaiger tcaiger tcaiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EMcQ-BES @tcaiger