Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move search bar #4747

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Move search bar #4747

merged 1 commit into from
Jul 18, 2023

Conversation

alexd-bes
Copy link
Contributor

Issue WAITP-1229:

Changes:

  • Added support for rowHeaderColumnTitle in ui-components/Matrix
  • Moved the search bar to be passed in as rowHeaderColumnTitle prop
  • Updated placeholder text to be Search...

Screenshots:

Screenshot 2023-07-18 at 1 47 58 pm

tcaiger
tcaiger approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@tcaiger tcaiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes

@alexd-bes alexd-bes merged commit a26727d into epic-frontend-rewrite Jul 18, 2023
@alexd-bes alexd-bes deleted the waitp-1229-matrix-search-styling branch July 18, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcaiger tcaiger tcaiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexd-bes @tcaiger